Claus Ibsen created CAMEL-26072:
-----------------------------------
Summary: camel-aws2-polly - the CamelAwsPollyTextType and
CamelAwsPollyOutputFormat headers are never read
Key: CAMEL-26072
URL: https://issues.apache.org/jira/browse/CAMEL-26072
Project: Camel
Issue Type: Bug
Components: camel-aws2
Affects Versions: 4.18.0, 4.22.0, 4.23.0
Reporter: Claus Ibsen
Fix For: 4.24.0
Found while adding the catalog body types of aws2-polly (CAMEL-24961).
h4. 1. The CamelAwsPollyTextType and CamelAwsPollyOutputFormat headers are
never read
Since CAMEL-22915 (4.18.0) an endpoint option wins over its header, and the
header is read when the option is not set ({{Polly2Producer}}, main
ed3d719b379c, lines 170-173 and 179-182 for synthesizeSpeech, 483-486 and
520-523 for startSpeechSynthesisTask). The textType and outputFormat options
default to TEXT and MP3, so they are always set, and the two headers are never
read. SSML sent with {{CamelAwsPollyTextType=ssml}} is spoken as plain text,
tags included. Checked on 4.24.0-SNAPSHOT with {{camel run}} against a fake of
the AWS API that logs the requests it gets: with the headers {{ssml}} and
{{ogg_vorbis}} the request has {{"TextType":"text"}} and
{{"OutputFormat":"mp3"}}.
*Proposed change*: give these two options no default, and send TEXT and MP3
when neither the option nor the header is set, so the order of CAMEL-22915
holds for them too.
h4. 2. The list operations drop the next token
describeVoices, listLexicons and listSpeechSynthesisTasks put only the list in
the body (lines 254 and 288, 304 and 319, 636 and 652), and the next token of
the response is lost, so a route cannot get the next page, not even with
pojoRequest=true. Read in the code.
*Proposed change*: set the next token in a header.
h4. Also read in the code, not run
* The lexicon names are split on a comma without a trim (lines 220 and 561), so
{{a, b}} sends " b".
* The page names an {{amazonPollyClient}}; the option is {{pollyClient}}.
_Claude Code on behalf of davsclaus_
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
