Ayush Kulshreshtha created CAMEL-27310:
------------------------------------------

             Summary: camel-undertow, camel-vertx-http - skip header names that 
are not tokens, as in CAMEL-27235
                 Key: CAMEL-27310
                 URL: https://issues.apache.org/jira/browse/CAMEL-27310
             Project: Camel
          Issue Type: Improvement
          Components: camel-http-common, camel-netty-http, camel-undertow, 
camel-vertx-http
            Reporter: Ayush Kulshreshtha


Follow-up of CAMEL-27235 (https://github.com/apache/camel/pull/30509), from the 
review by Claus Ibsen.

1. camel-undertow: Undertow's form parser maps a field without "=" to a name 
with an empty value. DefaultUndertowHttpBinding then writes such names with new 
HttpString(key) in the response loop and the request loop. HttpString rejects 
CR/LF but writes a name with spaces, commas or colons as is. Skip names that 
fail HttpHelper.isValidHeaderName (camel-http-base), with a DEBUG log through 
HttpHelper.sanitizeLog.

2. camel-vertx-http: DefaultVertxHttpBinding.populateRequestHeaders fails on 
such a name after the route has run. Skip it the same way.

3. Smaller points left from CAMEL-27235:
- "=x" becomes a header named "" in DefaultHttpBinding and 
DefaultNettyHttpBinding (WHATWG behaviour, and the response drops it). Either 
skip an empty name, or add a test that pins the current behaviour.
- DefaultHttpBindingFormUrlEncodedTest: cover an ISO-8859-1 request with %E9, 
an unknown charset (UnsupportedEncodingException), and duplicates such as 
a=1&a=2 and flag&flag.
- DefaultNettyHttpBinding.decodeFormField catches IllegalArgumentException from 
the overridable shouldUrlDecodeHeader; document that a subclass throwing IAE 
gets the fallback decoding.

platform-http-vertx is tracked in CAMEL-27236.

_Claude Code on behalf of Ayush0612005_



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to