[ 
https://issues.apache.org/jira/browse/CAMEL-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved CAMEL-7155.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.12.4

Applied the patch into camel-2.12.x and master branches.

> Incorrect implementation of the method StringHelper.hasStartToken()
> -------------------------------------------------------------------
>
>                 Key: CAMEL-7155
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7155
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.12.2
>            Reporter: Tomas Rohovsky
>            Assignee: Willem Jiang
>            Priority: Minor
>             Fix For: 2.12.4, 2.13.0
>
>
> From the semantic point of view the method hasStartToken() should return 
> false in case of an expression without language specified, i.e. starting with 
> "${". 
> However, it is correct to return true in current usage of hasStartToken() in 
> camel-core, i.e. checking if an expression is in simple language, since if 
> the expression does not contain the language token, then it is a simple 
> expression.
> The method calls for checking of simple language should be replaced with a 
> newly created method isSimpleLanguage(String expression) that would check if 
> the language is a simple expression, i.e. hasStartToken(expression, "simple") 
> || expression.indexOf("${") >= 0.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to