[ 
https://issues.apache.org/jira/browse/CAMEL-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201704#comment-14201704
 ] 

Willem Jiang commented on CAMEL-7908:
-------------------------------------

Hi Aaron,
Thanks for the comments, it's very helpful when I went through the patch. 
As you introduced a new DestinationCreationStrategy and did lots of clean up 
work (removing the unused code), I'm afraid I cannot merge the patch into 
camel-2.14.x branch.

BTW, I just updated the sjms wiki page with this new Option of 
DestinationCreateionStrategy. Please double check the page in case I missed 
something.


> Add a DestinationCreationStrategy to the SJMS component
> -------------------------------------------------------
>
>                 Key: CAMEL-7908
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7908
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-sjms
>    Affects Versions: 2.14.0
>            Reporter: Aaron Whiteside
>            Assignee: Willem Jiang
>            Priority: Minor
>             Fix For: 2.15.0
>
>         Attachments: destination_creation_strategy.patch, 
> destination_creation_strategy2.patch, unnamed2.patch
>
>
> Add a DestinationCreationStrategy to the SJMS component
> JMS implementations like HornetQ do not allow dynamic queue/topic creation 
> via the pure JMS API's. Extending SJMS with a DestinationCreationStrategy 
> would allow one to replace the DefaultDestinationCreationStrategy with a 
> provider specific one that in the case of HornetQ dynamically creates the 
> queue/topic using the correct management API.
> Implementation note:
> JmsObjectFactory::createMessageProducer would be modified to supply a 
> DestinationCreateionStrategy, it would then use this to obtain Destination's.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to