[
https://issues.apache.org/jira/browse/CAMEL-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321997#comment-14321997
]
Claus Ibsen commented on CAMEL-8345:
------------------------------------
I reverted the change as it causes unit tests to fail, as all the xml samples
was not updated.
We should either keep it as current, or use property, eg this kind
{code}
<restConfiguration>
<componentProperties>
<property key="" value=""/>
<property key="" value=""/>
</componentProperties>
<consumerProperties>
<property key="" value=""/>
<property key="" value=""/>
</consumerProperties>
</restConfiguration>
{code}
The latter is IMHO a good approach as <property> is common to use. But this
require a bit more work to introduce the definition types and adjust all xml
files so the unit tests and examples work.
> We should use Properties instead of Property to define the properties in
> restConfiguration
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-8345
> URL: https://issues.apache.org/jira/browse/CAMEL-8345
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.14.1
> Reporter: Willem Jiang
> Assignee: Willem Jiang
> Fix For: 2.15.0
>
>
> Current <restConfiguration> use xxxProperty to specify the properties, it is
> not the common usage. It could be better if we can fix it in Camel 2.15.0.
> {code}
> @XmlElement(name = "componentProperty")
> private List<RestPropertyDefinition> componentProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "endpointProperty")
> private List<RestPropertyDefinition> endpointProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "consumerProperty")
> private List<RestPropertyDefinition> consumerProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "dataFormatProperty")
> private List<RestPropertyDefinition> dataFormatProperties = new
> ArrayList<RestPropertyDefinition>();
> {code}
> The XmlElement need to be changed to
> {code}
> @XmlElement(name = "componentProperties")
> private List<RestPropertyDefinition> componentProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "endpointProperties")
> private List<RestPropertyDefinition> endpointProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "consumerProperties")
> private List<RestPropertyDefinition> consumerProperties = new
> ArrayList<RestPropertyDefinition>();
> @XmlElement(name = "dataFormatProperties")
> private List<RestPropertyDefinition> dataFormatProperties = new
> ArrayList<RestPropertyDefinition>();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
