[ 
https://issues.apache.org/jira/browse/CAMEL-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551428#comment-15551428
 ] 

ASF GitHub Bot commented on CAMEL-10358:
----------------------------------------

GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1199

    CAMEL-10358: do not clear the registry too early

    When running on Spring, the `doStop` is called by the spring framework 
before the default strategy unregisters the consumers, so the registry is 
cleared and the undertow servers remain bound to their port when the context is 
closed.
    
    We should not clear the registry (change added in 
https://github.com/apache/camel/commit/cdd64e10a6c761ccfba4b6d605c53df1250bb9eb)
 because it is automatically cleared when the last consumer is unregistered.
    
    This issue prevent using livereload with undertow (port already used). I'm 
working on a feature for dynamically changing the configuration on Kubernetes 
that is also be impacted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel CAMEL-10358

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1199
    
----
commit 537642b594bc24f8e3ae98897bf409e1ad4fa4b4
Author: Nicola Ferraro <[email protected]>
Date:   2016-10-06T09:11:59Z

    CAMEL-10358: do not clear the registry too early

----


> camel-spring-boot - Add example how to use Spring Boot Live Reload
> ------------------------------------------------------------------
>
>                 Key: CAMEL-10358
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10358
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-spring-boot
>            Reporter: Claus Ibsen
>            Assignee: Nicola Ferraro
>
> We should find out if spring boot live reload (dev tools) work well with 
> camel-spring-boot
> http://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-devtools.html
> Maybe there is a bug/issue somewhere or some limitations. But it would be 
> good to try this from an example and see what works or not. And if possible 
> fix this in camel-spring-boot so we can support super fast development 
> experience.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to