[ 
https://issues.apache.org/jira/browse/CAMEL-11149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051152#comment-16051152
 ] 

ASF GitHub Bot commented on CAMEL-11149:
----------------------------------------

GitHub user MarcinLachowicz opened a pull request:

    https://github.com/apache/camel/pull/1767

    CAMEL-11149 Maps JMH benchmarks: add complex cases for various header…

    … maps impl, tweak jmh config to produce readable results, fix checkstyle 
issue in SimpleMockTest.
    
    I've tweak JMH config a bit to get more readable results. It is ok, to use 
only one _mode_(SampleTime)_ in this case. Here are my results:
    
    ```
    Benchmark                                                                   
      Mode  Cnt     Score    Error  Units
    CaseInsensitiveMapTest.camelMapComplexCase                                  
    sample   15  1974.678 ± 31.294  ms/op
    CaseInsensitiveMapTest.camelMapSimpleCase                                   
    sample  236   107.242 ±  1.821  ms/op
    CaseInsensitiveMapTest.cedarsoftMapComplexCase                              
    sample   20  1400.898 ± 23.216  ms/op
    CaseInsensitiveMapTest.cedarsoftMapSimpleCase                               
    sample  221   113.891 ±  0.585  ms/op
    CaseInsensitiveMapTest.hashMapComplexCase                                   
    sample   55   495.986 ±  2.844  ms/op
    CaseInsensitiveMapTest.hashMapSimpleCase                                    
    sample  910    27.537 ±  0.156  ms/op
    
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MarcinLachowicz/camel 
CAMEL-11149-maps-jmh-benchmarks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1767
    
----
commit 808e17614651bb8656a603c39a96eabe24c94315
Author: Marcin Lachowicz <lachowicz.marc...@gmail.com>
Date:   2017-06-15T22:05:52Z

    CAMEL-11149 Maps JMH benchmarks: add complex cases for various header maps 
impl, tweak jmh config to produce readable results, fix checkstyle issue in 
SimpleMockTest

----


> SPI - Allow to plugin different headers map implementation
> ----------------------------------------------------------
>
>                 Key: CAMEL-11149
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11149
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.20.0
>
>
> See PR for background
> https://github.com/apache/camel/pull/1527
> We can introduce a SPI that allows 3rd party to plugin a custom 
> implementation of the headers map. Then you can use the default, that 3rd 
> party, or a case insensitive if the latter is sufficient. However typically 
> HTTP/REST based protocols are case insensitive headers.
> We should try to make it auto lookup from classpath using the factory finder 
> which we do with others like the hystrix eip etc. Then we could have a 
> camel-cedersoftware-java-util component which uses their implementation and 
> Camel can then auto detect it from classpath and use it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to