[
https://issues.apache.org/jira/browse/CAMEL-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180571#comment-16180571
]
ASF GitHub Bot commented on CAMEL-11814:
----------------------------------------
GitHub user zregvart opened a pull request:
https://github.com/apache/camel/pull/1961
CAMEL-11814: makes NO_START a ThreadLocal, and ...
...changes the way CamelMainRunController is started
We need to change NO_START flag back to ThreadLocal as there is a use
case when it's used from a single classloader outside of the tests in
wildfly-camel.
CamelMainRunController would atempt to start CamelContext from a thread
that does not have the NO_START flag defined (it's a ThreadLocal), so
it can only run when CamelContext is started. It's main purpose is to
prevent the SpringBoot application JVM from terminating so having it
run when the CamelContext is started doesn't prevent that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zregvart/camel CAMEL-11814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1961
----
commit b53773853e8fff5cad3854ed096812b844086080
Author: Zoran Regvart <zregv...@apache.org>
Date: 2017-09-26T10:03:12Z
CAMEL-11814: makes NO_START a ThreadLocal, and ...
...changes the way CamelMainRunController is started
We need to change NO_START flag back to ThreadLocal as there is a use
case when it's used from a single classloader outside of the tests in
wildfly-camel.
CamelMainRunController would atempt to start CamelContext from a thread
that does not have the NO_START flag defined (it's a ThreadLocal), so
it can only run when CamelContext is started. It's main purpose is to
prevent the SpringBoot application JVM from terminating so having it
run when the CamelContext is started doesn't prevent that.
----
> camel-spring-boot - Recent change in startup behaviour can cause
> camel-test-spring problems
> -------------------------------------------------------------------------------------------
>
> Key: CAMEL-11814
> URL: https://issues.apache.org/jira/browse/CAMEL-11814
> Project: Camel
> Issue Type: Bug
> Components: camel-spring, camel-spring-boot
> Affects Versions: 2.20.0
> Reporter: Claus Ibsen
> Assignee: Zoran Regvart
> Fix For: 2.20.0
>
>
> Creating this ticket up front as I was testing CiA2 source code with
> 2.20.0-SNAPSHOT and have issues with a camel spring boot app, that caused the
> test method to be executed without CamelContext been started prior - this
> works fine on 2.19.x and older versions.
> Its very likely the new startup/shutdown change in camel-spring /
> camel-spring-boot that is causing a regression problem. A bit weird our own
> set of unit tests at Apache Camel hasn't triggered this.
> Doing some more testing on CiA2 before posting more information here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
