[ 
https://issues.apache.org/jira/browse/CAMEL-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216531#comment-16216531
 ] 

ASF GitHub Bot commented on CAMEL-11925:
----------------------------------------

GitHub user jamesnetherton opened a pull request:

    https://github.com/apache/camel/pull/2056

    CAMEL-11925: Migrate atmos properties file configuration to component 
properties

    https://issues.apache.org/jira/browse/CAMEL-11925

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jamesnetherton/camel CAMEL-11925

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2056
    
----
commit 1cdd53706431f4fdbfac6294f1e2a2373ba2cc37
Author: James Netherton <[email protected]>
Date:   2017-10-24T07:37:32Z

    CAMEL-11925: Migrate atmos properties file configuration to component 
properties

----


> Atmos component fails to load atmos.properties in a modular class loading 
> environment 
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-11925
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11925
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-atmos
>    Affects Versions: 2.20.0
>            Reporter: James Netherton
>            Assignee: James Netherton
>             Fix For: 2.20.1, 2.21.0
>
>
> The atmos component has a AtmosPropertyManager class which attempts to do:
> {code}
> AtmosPropertyManager.class.getResource("/atmos.properties");
> {code}
> This assumes the resource is available to the ClassLoader of 
> AtmosPropertyManager. This may not be the case in OSGi or JavaEE containers.
> I see there's a [TODO 
> comment|https://github.com/apache/camel/blob/master/components/camel-atmos/src/main/java/org/apache/camel/component/atmos/util/AtmosPropertyManager.java#L26]
>  at the top of this class. So maybe we remove this class and make it so we 
> configure these properties on the component instead?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to