[ 
https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221835#comment-16221835
 ] 

ASF GitHub Bot commented on CAMEL-11948:
----------------------------------------

GitHub user Thopap opened a pull request:

    https://github.com/apache/camel/pull/2064

    CAMEL-11948  NPE on DefaultMessage setBody if deprecated constructor was 
used

    After upgrade camel 2.20.0, some operations fail with a 
NullPointerException:
    
    ```
    Caused by: java.lang.NullPointerException
            at 
org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122)
    ```
    
    The issue seems to be introduced with the change CAMEL-11380.
    
    The issue could be easily reproduced by using the deprecated constructor, 
where no camelContext is set:
    
    ```
            Message message = new DefaultMessage();
            message.setBody("something");
    ```
    
    To remain better backward compatibility, i would suggest a nullcheck in the 
setBody for cases where the CamelContext is not set.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Thopap/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2064
    
----
commit 14baabbfaeb6edf53080b27c7984135d7af453d6
Author: Thomas Papke <thomas.pa...@icw.de>
Date:   2017-10-26T15:31:56Z

    CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was
    used

commit 4701576cc2f140b829726a1ad529e82090f1e4ee
Author: Thomas Papke <thomas.pa...@icw.de>
Date:   2017-10-27T07:02:25Z

    CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was
    used
    * Adding test

----


> NPE on DefaultMessage setBody if deprecated constructor was used
> ----------------------------------------------------------------
>
>                 Key: CAMEL-11948
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11948
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.20.0
>            Reporter: Thomas Papke
>            Priority: Minor
>             Fix For: 2.21.0
>
>
> After upgrade camel 2.20.0, some operations fail with a NullPointerException:
> {code}
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122)
> {code}
> The issue seems to be introduced with the change CAMEL-11380.
> The issue could be easily reproduced by using the deprecated constructor, 
> where no camelContext is set:
> {code}
>         Message message = new DefaultMessage();
>         message.setBody("something");
> {code}
> To remain better backward compatibility, i would suggest a nullcheck in the 
> setBody for cases where the CamelContext is not set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to