[jira] [Commented] (CAMEL-12102) Improve camel-sap-netweaver documentation

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CAMEL-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303918#comment-16303918
 ] 

ASF GitHub Bot commented on CAMEL-12102:
----------------------------------------

GitHub user eximius313 opened a pull request:

    https://github.com/apache/camel/pull/2155

    Add "command" header to the example

    Fixes https://issues.apache.org/jira/browse/CAMEL-12102

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eximius313/camel patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2155
    
----
commit 47b46ff3cdcce79d5bb1a6268a4079d89777b403
Author: Kamil <eximius313@...>
Date:   2017-12-26T16:19:26Z

    Add "command" header to the example
    
    Fixes https://issues.apache.org/jira/browse/CAMEL-12102

----


> Improve camel-sap-netweaver documentation
> -----------------------------------------
>
>                 Key: CAMEL-12102
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12102
>             Project: Camel
>          Issue Type: Improvement
>            Reporter: Kamil
>            Assignee: Claus Ibsen
>
> [Documentation|http://camel.apache.org/sap-netweaver.html] defines:
> {code}
> private String command = 
> "FlightCollection(AirLineID=&#39;AA&#39;,FlightConnectionID=&#39;0017&#39;,FlightDate=datetime&#39;2012-08-29T00%3A00%3A00&#39;)";
> {code}
> which is never used in
> {code}
> from("direct:start")
>     .toF("sap-netweaver:%s?username=%s&password=%s", url, username, password)
>     .to("log:response")
>     .to("velocity:flight-info.vm")
> {code}
> so please provide valid example of how to use commands.
> By the way - it would be great if you could correct the format of:
> {code}
> lightCollection(AirLineID=&#39;AA&#39;,FlightConnectionID=&#39;0017&#39;,FlightDate=datetime&#39;2012-08-29T00%3A00%3A00&#39;)
> {code}
> because it is not readable



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)