[ 
https://issues.apache.org/jira/browse/CAMEL-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467374#comment-16467374
 ] 

christian ohr commented on CAMEL-12493:
---------------------------------------

Ahh, wasn't aware of this option... Yes, I would agree then.

> Remove recently added additional HL7 Type Converters
> ----------------------------------------------------
>
>                 Key: CAMEL-12493
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12493
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-hl7
>    Affects Versions: 2.21.0
>            Reporter: christian ohr
>            Priority: Major
>
> In Camel 2.21.0, HL7-version/event-specific type converters were added to 
> camel-hl7. IMHO this was a bad idea:
>  * it transitively pulls in *all* HL7 structure libraries, regardless whether 
> you need them in your application or not. That's nearly 10MB. Btw, type 
> converters for the newer HL7 versions 2.7, 2.8, 2.8.1 were simply 
> disregarded, which would have gifted you with another ~ 7.5MB.
>  * manually excluding one or more of them causes the 
> AnnotationTypeConverterLoader to throw ugly NoClassDefFoundError stack traces 
> in the log
>  * the component documentation states that you have to manually add structure 
> library dependencies (the way it should be, really)
> Proposal: remove these type converters. I think it's acceptable to do a 
> simple type cast in a processor or add a manual \{{convertBodyTo(HL7Class)}} 
> in the route instead.
> Opinions? (I'm happy to provide a PR :))



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to