[ 
https://issues.apache.org/jira/browse/CAMEL-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514407#comment-16514407
 ] 

ASF GitHub Bot commented on CAMEL-6840:
---------------------------------------

aldettinger commented on a change in pull request #2376: CAMEL-6840 - add 
grouped throttling feature, XML DSL is not working p…
URL: https://github.com/apache/camel/pull/2376#discussion_r195866104
 
 

 ##########
 File path: 
components/camel-spring/src/test/resources/org/apache/camel/spring/processor/ThrottlerGroupingTest.xml
 ##########
 @@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="UTF-8"?>
 
 Review comment:
   Globally, you have 2 issues. It is not valid against the xml schema, and the 
test is not the exact translation of the java DSL `ThrottlingGroupingTest` 
tests. Examples below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow Throttler EIP to specify SLA per client/correlated-group
> --------------------------------------------------------------
>
>                 Key: CAMEL-6840
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6840
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core, eip
>            Reporter: Christian Posta
>            Assignee: Önder Sezgin
>            Priority: Major
>             Fix For: 2.22.0
>
>
> Basic idea is to allow throttler to have a predicate to determine whether or 
> not to apply throttling to that exchange. 
> From this Mailing List discussion:
> http://camel.465427.n5.nabble.com/Throttling-by-client-ID-td5741032.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to