[jira] [Commented] (CAMEL-12647) Problem in setting region for camel AWS-SQS endpoint

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CAMEL-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542682#comment-16542682
 ] 

ASF GitHub Bot commented on CAMEL-12647:
----------------------------------------

oscerd commented on a change in pull request #2424: CAMEL-12647 : Problem in 
setting region for camel AWS-SQS endpoint
URL: https://github.com/apache/camel/pull/2424#discussion_r202272063
 
 

 ##########
 File path: 
components/camel-aws/src/test/java/org/apache/camel/component/aws/sqs/SqsComponentConfigurationTest.java
 ##########
 @@ -73,9 +73,9 @@ public void createEndpointWithMinimalArnConfiguration() 
throws Exception {
         
         ((JndiRegistry) ((PropertyPlaceholderDelegateRegistry) 
context.getRegistry()).getRegistry()).bind("amazonSQSClient", mock);
         SqsComponent component = new SqsComponent(context);
-        SqsEndpoint endpoint = (SqsEndpoint) 
component.createEndpoint("aws-sqs://arn:aws:sqs:region:account:MyQueue?amazonSQSClient=#amazonSQSClient&accessKey=xxx&secretKey=yyy");
+        SqsEndpoint endpoint = (SqsEndpoint) 
component.createEndpoint("aws-sqs://arn:aws:sqs:region:account:MyQueue?amazonSQSClient=#amazonSQSClient&accessKey=xxx&secretKey=yyy&region=US_EAST_2");
 
-        assertEquals("region", endpoint.getConfiguration().getRegion());
 
 Review comment:
   The example of arn for an sqs endpoint is 
arn:aws:sqs:us-east-1:123456789012:MyQueue. The problem is that we are using 
the enum value of the Regions class, so probably we may need to double check if 
the region is specified as arn, then we need to manipulate it to use it and 
make it compliant to be used for the enum.  In my opinion the PR must be 
reviewed in this way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Problem in setting region for camel AWS-SQS endpoint
> ----------------------------------------------------
>
>                 Key: CAMEL-12647
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12647
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-aws
>    Affects Versions: 2.21.1
>            Reporter: Saravanakumar Selvaraj
>            Priority: Major
>
> It gives FailedToCreateRouteException while creating camel AWS-SQS endpoint 
> with ARN.
> For example, below producer or consumer endpoint is not being created.
> {code:java}
> uri="aws-sqs://arn:aws:sqs:us-east-2:account:MyQueue?accessKey=xxx&secretKey=yyy&region=US_EAST_2"{code}
> And it throws error as follows.
> {code:java}
> Caused by: java.lang.IllegalArgumentException: No enum constant 
> com.amazonaws.regions.Regions.us-east-2
>       at java.lang.Enum.valueOf(Enum.java:238)
>       at com.amazonaws.regions.Regions.valueOf(Regions.java:26)
>       at 
> org.apache.camel.component.aws.sqs.SqsEndpoint.createClient(SqsEndpoint.java:310)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)