[ https://issues.apache.org/jira/browse/CAMEL-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-12730: -------------------------------- Issue Type: Task (was: Bug) > FindBugs warnings: Suspicious reference comparison > -------------------------------------------------- > > Key: CAMEL-12730 > URL: https://issues.apache.org/jira/browse/CAMEL-12730 > Project: Camel > Issue Type: Task > Components: camel-core > Reporter: Hiroaki Yoshida > Priority: Major > Fix For: 2.23.0 > > > FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 2 > RC_REF_COMPARISON warnings on master: > {code:java} > H C RC: Suspicious comparison of Integer references in > org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(Exchange) > At Throttler.java:[line 312] > H C RC: Suspicious comparison of Integer references in > org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(DelayQueue, > Exchange, Integer) At Throttler.java:[line 360] > {code} > The description of the bug is as follows: > {quote}*RC: Suspicious reference comparison (RC_REF_COMPARISON)* > This method compares two reference values using the == or != operator, where > the correct way to compare instances of this type is generally with the > equals() method. It is possible to create distinct instances that are equal > but do not compare as == since they are different objects. Examples of > classes which should generally not be compared by reference are > java.lang.Integer, java.lang.Float, etc. > [http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON] > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)