[
https://issues.apache.org/jira/browse/CAMEL-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717402#comment-16717402
]
ASF GitHub Bot commented on CAMEL-12991:
----------------------------------------
onderson commented on a change in pull request #2665: CAMEL-12991 setting
processStrategy for sftp/ftp endpoints
URL: https://github.com/apache/camel/pull/2665#discussion_r240663382
##########
File path:
components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/FtpConsumerProcessStrategyTest.java
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.file.remote;
+
+import org.apache.camel.Exchange;
+import org.apache.camel.component.file.GenericFile;
+import org.apache.camel.component.file.GenericFileEndpoint;
+import org.apache.camel.component.file.GenericFileOperations;
+import org.apache.camel.component.file.GenericFileProcessStrategy;
+import org.apache.camel.impl.JndiRegistry;
+import org.junit.Test;
+
+/**
+ * @author Seweryn Walendzik on 12/11/18.
Review comment:
please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SftpEndpoint does not allow to use custom process strategy
> ----------------------------------------------------------
>
> Key: CAMEL-12991
> URL: https://issues.apache.org/jira/browse/CAMEL-12991
> Project: Camel
> Issue Type: Bug
> Components: camel-ftp
> Affects Versions: 2.23.0
> Reporter: Seweryn Walendzik
> Priority: Minor
> Fix For: 3.0.0, 2.24.0, 2.23.1
>
>
> SftpEndpoint always create generic file strategy even processStrategy object
> is set in endpoint, same code is used in FtpEndpoint so it's not working also
> {code:java}
> @Override
> protected RemoteFileConsumer<SftpRemoteFile> buildConsumer(Processor
> processor) {
> return new SftpConsumer(this, processor, createRemoteFileOperations(),
> createGenericFileStrategy());
> }{code}
> it is working in FileEnpoint
> {code:java}
> protected FileConsumer newFileConsumer(Processor processor,
> GenericFileOperations<File> operations) {
> return new FileConsumer(this, processor, operations, processStrategy !=
> null ? processStrategy : createGenericFileStrategy());
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
