[
https://issues.apache.org/jira/browse/CAMEL-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139486#comment-17139486
]
ASF GitHub Bot commented on CAMEL-14958:
----------------------------------------
AemieJ commented on a change in pull request #398:
URL: https://github.com/apache/camel-website/pull/398#discussion_r442297448
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -131,11 +131,14 @@
--footer-height: 23rem; /* empirically corresponding current design of the
foooter */
/* dimensions */
--navbar-height: calc(73 / var(--rem-base) * 1rem);
+ --toolbar-nav-height: calc(139.5 / var(--rem-base) * 1rem);
+ --panel-height: calc(54 / var(--rem-base) * 1rem);
Review comment:
Alright, the toolbar nav height is introduced for the width < 1275 as we
introduce the whole search design below the actual navbar including the logo
and social icons.
Now with the changes, I observed that within the menu panel height under the
docs section, the panel items overflow to the footer due to the height defined.
Hence, the panel height is used to prevent the overflow.
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -131,11 +131,14 @@
--footer-height: 23rem; /* empirically corresponding current design of the
foooter */
/* dimensions */
--navbar-height: calc(73 / var(--rem-base) * 1rem);
+ --toolbar-nav-height: calc(139.5 / var(--rem-base) * 1rem);
+ --panel-height: calc(54 / var(--rem-base) * 1rem);
Review comment:
Alright, the toolbar nav height is introduced for the width < 1275 as we
introduce the whole search design below the actual navbar including the logo
and social icons.
Now with the changes, I observed that within the menu panel height under the
docs section, the panel items overflow to the footer due to the height defined.
Hence, the panel height is used to prevent the overflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Suggestion on search bar within smaller screen width.
> -----------------------------------------------------
>
> Key: CAMEL-14958
> URL: https://issues.apache.org/jira/browse/CAMEL-14958
> Project: Camel
> Issue Type: Improvement
> Components: website
> Reporter: Aemie
> Priority: Major
> Labels: outreachy2020, suggestions
> Attachments: bootstrap-design-blog.png,
> bootstrap-design-frontpage.png, design-frontpage.png, design-navbar.png,
> inline-search.png, issue-facing.png, nav-search-icon-1220.png,
> nav-searchbar-1220.png, nav-searchbar-414.png, navbar-search-414.png,
> navbar-searchbar.png
>
>
> Within the small width screen, the setting is to only display the social icon
> button as of now. However, I thought it would be a good idea to include the
> search icon alongside the social button icons. On click of the social button
> icons, we could include animation, for instance, a fade-in effect of the
> search bar occupying the entire navbar. The user can do the search as
> required. On the left side of the search bar, there will be back arrow, which
> on click would give us the original navbar look with a fade-out effect.
> Before I start working on this, I would like an opinion about this idea.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
