[
https://issues.apache.org/jira/browse/CAMEL-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160362#comment-17160362
]
ASF GitHub Bot commented on CAMEL-15185:
----------------------------------------
AemieJ commented on a change in pull request #428:
URL: https://github.com/apache/camel-website/pull/428#discussion_r456762637
##########
File path: antora-ui-camel/src/js/06-mobile-footer.js
##########
@@ -0,0 +1,15 @@
+document.addEventListener('DOMContentLoaded', function () {
Review comment:
While the `:target` selector works with toggling, it causes unnecessary
scrolling in pages. I will try with the use of a `:checked` selector as well
but if it works toggling with the checked selector in this scenario, I think in
that way we could minimize the use of javascript for navbar burger toggling and
the dropdown menu toggling for the mobile version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve Footer on Camel Website
> -------------------------------
>
> Key: CAMEL-15185
> URL: https://issues.apache.org/jira/browse/CAMEL-15185
> Project: Camel
> Issue Type: Improvement
> Components: website
> Reporter: Aashna Jena
> Priority: Major
> Labels: outreachy2020, suggestions
> Attachments: footer-arrangement-626.png, footer-design-2.png,
> footer-design.png, footer-mobile-1.1.png, footer-mobile-1.2.png
>
>
> I have some reservations about the website footer. On the mobile view, the
> footer takes up almost the entire height of my device because the Overview,
> Community and About columns do not fit into one row. Secondly, on the desktop
> view, the header navigation is fixed at the top, so I can view the header
> menu while I'm at the footer of the page. Having same links visible on the
> header menu and footer doesn't make sense to me (Download, Community, Blog
> etc). I do see a lot of websites having menu links on the footer, but they
> don't have a fixed navbar.
> Suggestions : I looked up best practices for footers. I think we can reduce
> the number of links we display on the footer, especially the ones overlapping
> with header menu. We can also add some things (from what I read up on best
> practices) - form for subscribing to the mailing list, sitemap link, contact
> information, link to report a bug on the website, privacy policy/ terms of
> use (if we have) and maybe a subscription for the blog, since we have quite
> informative and regular blog posts. I also really like the idea of having a
> row of social media icons in the footer, which a lot of websites do. This
> will give us the freedom of adding many more icons than on the header menu.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
