Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190103691 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -92,8 +93,10 @@ public DimensionColumnPage decodeColumnPage(int pageNumber) { * @param index * @return */ - public DimensionColumnPage convertToDimColDataChunkWithOutCache(int index) { + public DimensionColumnPage convertToDimColDataChunkWithOutCache(int index, + boolean isLongStringColumn) { --- End diff -- What does `reader` mean?
---