[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2252#discussion_r190104257
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java
 ---
    @@ -99,6 +99,7 @@ public CompressedDimensionChunkFileBasedReaderV1(final 
BlockletInfo blockletInfo
     
       @Override public DimensionColumnPage decodeColumnPage(
           DimensionRawColumnChunk dimensionRawColumnChunk, int pageNumber) 
throws IOException {
    +    boolean isLongStringColumn = 
dimensionRawColumnChunk.isLongStringColumn();
    --- End diff --
    
    I know, you mean just leave it false?


---