Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201226314
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void fillLegacyFields(DataChunk2 dataChunk)
public static EncodedColumnPage encodedColumn(ColumnPage page)
throws IOException, MemoryException {
- ColumnPageEncoder encoder = new
DirectCompressCodec(DataTypes.BYTE_ARRAY).createEncoder(null);
- return encoder.encode(page);
+ ColumnPageEncoder pageEncoder = createCodecForDimension(page);
--- End diff --
Looping logic is not required as only one particular column will only come
during execution. No need to further drill down to its children.
---
