Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2417#discussion_r201242475
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
 ---
    @@ -359,38 +412,36 @@ public void freeMemory() {
         }
       }
     
    -  @Override
    -  public void convertValue(ColumnPageValueConverter codec) {
    -    int pageSize = getPageSize();
    +  @Override public void convertValue(ColumnPageValueConverter codec) {
         if (dataType == DataTypes.BYTE) {
    -      for (long i = 0; i < pageSize; i++) {
    +      for (long i = 0; i < totalLength / ByteUtil.SIZEOF_BYTE; i++) {
    --- End diff --
    
    Done


---

Reply via email to