GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2564

    [CARBONDATA-2785][ExternalFormat] Optimize table pruning info for pruning 
by segment

    In previous implementation, table pruning is performed once for all
    segments. In this case, the pruning info is updated after default/CG/FG
    datamap pruning.
    
    Now we want the table pruning to be performed segment by segment, so in
    this case, the pruning info will be updated after default/CG/FG datamap
    pruning for each segment.
    
    This means that we need to accumulate the pruning info during pruning.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     `Only internal interfaces changed`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
    `NO, only optimize procedure`
            - How it is tested? Please attach test report.
    `Tested in local`
            - Is it a performance related change? Please attach the performance 
test report.
    `NO`
            - Any additional information to help reviewers in testing this 
change.
    `NO`
           
     - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 
0726_getsplits_by_segment

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2564
    
----
commit c8812c517be0bf61f61720d4c860022554fb6447
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-26T07:19:36Z

    optimize table pruning info for pruning by segment
    
    In previous implementation, table pruning is performed once for all
    segments. In this case, the pruning info is updated after default/CG/FG
    datamap pruning.
    
    Now we want the table pruning to be performed segment by segment, so in
    this case, the pruning info will be updated after default/CG/FG datamap
    pruning for each segment.
    
    This means that we need to accumulate the pruning info during pruning.

----


---

Reply via email to