Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2564#discussion_r206419989
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -245,9 +245,17 @@ public CarbonTable
getOrCreateCarbonTable(Configuration configuration) throws IO
FilterResolverIntf filterInterface = carbonTable.resolveFilter(filter);
// do block filtering and get split
- List<InputSplit> splits =
- getSplits(job, filterInterface, filteredSegmentToAccess,
matchedPartitions, partitionInfo,
- null, updateStatusManager);
+ List<InputSplit> splits = new ArrayList<>();
+ for (Segment segment : filteredSegmentToAccess) {
+ List<InputSplit> splitsPerSegment = getSplitsForSegment(job,
filterInterface, segment,
--- End diff --
There is func called getSplitsOfOneSegment, can you change both func name
to make it more readable
---
