Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2791#discussion_r221449108
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
 ---
    @@ -208,7 +209,10 @@ class CarbonFileMetastore extends CarbonMetaStore {
         try {
           lookupRelation(tableIdentifier)(sparkSession)
         } catch {
    -      case _: Exception =>
    +      case ex: Exception =>
    +        if (ex.getCause.isInstanceOf[HiveException]) {
    +          throw ex
    +        }
    --- End diff --
    
    i suggest if you are  skipping the exception propagation, better you log 
the reason why you are returning false.
    this will be better for a secondary developer to locate the exact problem 
from a log  in some unwanted failure scenarios.


---

Reply via email to