Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2791#discussion_r221449294
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
 ---
    @@ -208,7 +209,10 @@ class CarbonFileMetastore extends CarbonMetaStore {
         try {
           lookupRelation(tableIdentifier)(sparkSession)
         } catch {
    -      case _: Exception =>
    +      case ex: Exception =>
    +        if (ex.getCause.isInstanceOf[HiveException]) {
    +          throw ex
    +        }
    --- End diff --
    
    I think it will better to have a testcases here? i can see from your code 
in CarbonFileMetastore.scala  that you are only expecting a HiveException type 
to be thrown out, other exceptions you are ignoring.


---

Reply via email to