akashrn5 commented on a change in pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#discussion_r289323471
########## File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/rewrite/MVExceptionTestCase.scala ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.carbondata.mv.rewrite + +import org.apache.carbondata.common.exceptions.sql.MalformedDataMapCommandException +import org.apache.spark.sql.catalyst.analysis.NoSuchTableException +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +class MVExceptionTestCase extends QueryTest with BeforeAndAfterAll { + override def beforeAll: Unit = { + drop() + sql("create table main_table (name string,age int,height int) stored by 'carbondata'") + } + + test("test mv no base table") { + val ex = intercept[NoSuchTableException] { + sql("create datamap main_table_mv on table main_table_error using 'mv' as select sum(age),name from main_table group by name") + } + assertResult("Table or view 'main_table_error' not found in database 'default';")(ex.getMessage()) + } + + test("test mv reduplicate mv table") { + val ex = intercept[MalformedDataMapCommandException] { + sql("create datamap main_table_mv1 on table main_table using 'mv' as select sum(age),name from main_table group by name") + sql("create datamap main_table_mv1 on table main_table using 'mv' as select sum(age),name from main_table group by name") + } + assertResult("DataMap with name main_table_mv1 already exists in storage")(ex.getMessage) + } + + def drop(): Unit = { + sql("drop table IF EXISTS main_table") + sql("drop table if exists main_table_error") + sql("drop datamap if exists main_table_mv") Review comment: you can remove drop datamap here, as main table drop will take care to drop datamaps also ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
