akashrn5 commented on a change in pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#discussion_r289324316
########## File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/rewrite/MVValidFunctionTest.scala ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.carbondata.mv.rewrite + +import org.apache.spark.sql.Row +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +class MVValidFunctionTest extends QueryTest with BeforeAndAfterAll { + + override def beforeAll(): Unit = { + drop + sql("create table main_table (name string,age int,height int) stored by 'carbondata'") + sql("create table dim_table (name string,age int,height int) stored by 'carbondata'") + sql("create table sdr_table (name varchar(20),score int) stored by 'carbondata'") + } + + def drop() { + sql("drop table if exists main_table") + sql("drop datamap if exists main_table_mv") Review comment: same as above, you can remove drop datamap query from here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
