ajantha-bhat commented on a change in pull request #4044:
URL: https://github.com/apache/carbondata/pull/4044#discussion_r537258139
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##########
@@ -2123,29 +2123,35 @@ public int getMaxSIRepairLimit(String dbName, String
tableName) {
* folder will take place
*/
private void validateTrashFolderRetentionTime() {
- String propertyValue = carbonProperties.getProperty(CarbonCommonConstants
- .CARBON_TRASH_RETENTION_DAYS, Integer.toString(CarbonCommonConstants
- .CARBON_TRASH_RETENTION_DAYS_DEFAULT));
+ String propertyValue = carbonProperties.getProperty(
Review comment:
@akashrn5 : getTrashFolderRetentionTime is used to access the already
validated and stored value. It won't check the parsing errors as it is already
validated. so current changes looks ok for me for this first time validation
for add property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
