ajantha-bhat commented on a change in pull request #4044:
URL: https://github.com/apache/carbondata/pull/4044#discussion_r537260678
##########
File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java
##########
@@ -192,20 +192,20 @@ public static void emptyTrash(String tablePath) {
}
/**
- * This will tell whether the trash retention time has expired or not
- *
- * @param fileTimestamp
- * @return
+ * whether trash data inside of .Trash folder is time out
+ */
+ private static boolean isTrashRetentionTimeoutExceeded(long fileTimestamp) {
+ int retentionDays =
CarbonProperties.getInstance().getTrashFolderRetentionTime();
+ long retentionMilliSeconds = TimeUnit.DAYS.toMillis(1) * retentionDays;
+ return CarbonUpdateUtil.readCurrentTime() - fileTimestamp >
retentionMilliSeconds;
+ }
+
+ /**
+ * whether trash data outside of .Trash folder is time out
*/
- public static boolean isTrashRetentionTimeoutExceeded(long fileTimestamp) {
- // record current time.
- long currentTime = CarbonUpdateUtil.readCurrentTime();
- long retentionMilliSeconds =
(long)Integer.parseInt(CarbonProperties.getInstance()
- .getProperty(CarbonCommonConstants.CARBON_TRASH_RETENTION_DAYS,
Integer.toString(
- CarbonCommonConstants.CARBON_TRASH_RETENTION_DAYS_DEFAULT))) *
TimeUnit.DAYS
- .toMillis(1);
- long difference = currentTime - fileTimestamp;
- return difference > retentionMilliSeconds;
+ public static boolean isTrashDataTimeout(long fileTimestamp) {
Review comment:
```suggestion
public static boolean isDataOutsideTrashIsExpired(long fileTimestamp) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
