Github user ravipesala commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721876
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
 ---
    @@ -375,6 +376,9 @@ private void writeDataWithOutKettle(Object[][] 
recordHolderList, int entryCountL
                 stream.write((byte) 0);
               }
             }
    +        if (i % 10000 == 9999) {
    --- End diff --
    
    it is unnecessary calculation we are adding in it. Already the buffer size 
is configurable so once buffer size reaches buffered out stream can flush it 
down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to