Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101462875 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java --- @@ -39,11 +39,13 @@ * Sorts the data of all iterators, this iterators can be * read parallely depends on implementation. * - * @param iterators array of iterators to read data. * @return * @throws CarbonDataLoadingException */ - Iterator<CarbonRowBatch>[] sort(Iterator<CarbonRowBatch>[] iterators) + Iterator<CarbonRowBatch>[] sort() + throws CarbonDataLoadingException; + + void prepare(Iterator<CarbonRowBatch>[] iterators) --- End diff -- fixed
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---