turboFei commented on code in PR #3427:
URL: https://github.com/apache/celeborn/pull/3427#discussion_r2280949426
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -894,6 +896,14 @@ private[celeborn] class Master(
val numReducers = requestSlots.partitionIdList.size()
val shuffleKey = Utils.makeShuffleKey(requestSlots.applicationId,
requestSlots.shuffleId)
+ if (numReducers > slotAssignMaxPartitions) {
+ logError(s"reject $shuffleKey to request $numReducers partitions, which
exceeds $slotAssignMaxPartitions")
+ context.reply(RequestSlotsResponse(StatusCode.REQUEST_FAILED, new
WorkerResource()))
+ return
+ } else if (numReducers > slotAssignWarningPartitions) {
+ logWarning(s"too much partitions, $shuffleKey requests $numReducers
exceeds $slotAssignWarningPartitions")
Review Comment:
we audit the all the partitions number, it is not necessary to log warning.
https://github.com/apache/celeborn/pull/3265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
