turboFei commented on code in PR #3427:
URL: https://github.com/apache/celeborn/pull/3427#discussion_r2280949896
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3054,6 +3056,24 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(2)
+ val MASTER_SLOT_ASSIGN_MAX_PARTITIONS: ConfigEntry[Int] =
+ buildConf("celeborn.master.slot.assign.maxPartitions")
+ .withAlternative("celeborn.slots.assign.maxPartitions")
+ .categories("master")
+ .version("0.6.0")
+ .doc("Max partition numbers that one shuffle can be allocated, reject if
exceeds")
+ .intConf
+ .createWithDefault(50000)
Review Comment:
it would fail the applications and is a break change, default value could be
Int.MaxValue
You can set a threshold to fallback in client end.
https://github.com/apache/celeborn/blob/main/client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/ShufflePartitionsFallbackPolicy.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
