FMX commented on code in PR #3451:
URL: https://github.com/apache/celeborn/pull/3451#discussion_r2313261379
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3736,6 +3738,15 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("220s")
+ val WORKER_PARTITION_SORTER_SORT_TIME_LOG_THRESHOLD: ConfigEntry[Long] =
+ buildConf("celeborn.worker.sortPartition.sortTimeLogThreshold")
+ .categories("worker")
+ .doc("When sort time exceeds this threshold, log the file id and sort
duration. " +
+ "Set to 0 to disable logging.")
+ .version("0.7.0")
+ .timeConf(TimeUnit.MILLISECONDS)
+ .createWithDefaultString("220s")
Review Comment:
Changing the value to 30s makes no sense because the sort time is variable
due to disk status and other conditions. The original parameter shows timed-out
sort tasks and files, which can be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
