mridulm commented on code in PR #3451:
URL: https://github.com/apache/celeborn/pull/3451#discussion_r2335201270
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -799,6 +804,16 @@ public void sort() {
sorting.remove(fileId);
}
}
+ long sortDuration = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
sortStartTime);
Review Comment:
Note: I was planning to suggest making `sortDuration` and `sortStartTime`
conditioned on `sortTimeLogThreshold > 0` : but given the default value is
always non zero, this does not help much !
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -692,6 +695,7 @@ class FileSorter {
this.fileId = fileId;
this.shuffleKey = shuffleKey;
this.indexFilePath = Utils.getIndexFilePath(originFilePath);
+ this.sortTimeLogThreshold =
PartitionFilesSorter.this.sortTimeLogThreshold;
Review Comment:
nit: We dont need this local variable - can directly reference
`PartitionFilesSorter.this.sortTimeLogThreshold` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
