SteNicholas commented on code in PR #3471: URL: https://github.com/apache/celeborn/pull/3471#discussion_r2346293144
########## client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala: ########## @@ -248,12 +248,15 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends private val messagesHelper: TransportMessagesHelper = new TransportMessagesHelper() + private val extraInfo = ApplicationInfoProvider.instantiate(conf) + .provide() + (CelebornConf.QUOTA_INTERRUPT_SHUFFLE_ENABLED.key -> conf.quotaInterruptShuffleEnabled.toString) Review Comment: IMO, this config should not move to the default implementation. Otherwise, other implementation should also consider this config, which could not require this behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
