SteNicholas commented on code in PR #3471:
URL: https://github.com/apache/celeborn/pull/3471#discussion_r2354083807
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/quota/QuotaManager.scala:
##########
@@ -339,12 +350,14 @@ class QuotaManager(
var nonExpired = used
if (checkConsumptionExceeded(used, threshold)) {
val sortedConsumption =
- appMap.sortBy(_._2)(Ordering.by((r: ResourceConsumption) =>
- (
- r.diskBytesWritten,
- r.diskFileCount,
- r.hdfsBytesWritten,
- r.hdfsFileCount)).reverse)
+ appMap.filter(app =>
+ appQuotaConfig.getOrDefault(app._1,
defaultQuotaConfig).quotaInterruptShuffleEnabled)
Review Comment:
@FMX, `interruptShuffleEnabled` is used for server instead of application.
When `interruptShuffleEnabled` is true, the `quotaInterruptShuffleEnabled` of
application may be false for high priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
