xy2953396112 commented on code in PR #3471:
URL: https://github.com/apache/celeborn/pull/3471#discussion_r2345937527


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -248,12 +248,15 @@ class LifecycleManager(val appUniqueId: String, val conf: 
CelebornConf) extends
 
   private val messagesHelper: TransportMessagesHelper = new 
TransportMessagesHelper()
 
+  private val extraInfo = ApplicationInfoProvider.instantiate(conf)
+    .provide() + (CelebornConf.QUOTA_INTERRUPT_SHUFFLE_ENABLED.key -> 
conf.quotaInterruptShuffleEnabled.toString)

Review Comment:
   Should move `(CelebornConf.QUOTA_INTERRUPT_SHUFFLE_ENABLED.key -> 
conf.quotaInterruptShuffleEnabled.toString)` to 
`DefaultApplicationInfoProvider#provide()` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to