[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090925#comment-14090925
 ] 

Marcus Sorensen commented on CLOUDSTACK-5512:
---------------------------------------------

I should also mention that there are some hosted templates from high profile 
companies that use the wrong extension (in our view), for example ubuntu hosts 
vm templates that are qcow2 as '.img' files.

> template format name checking is crude and doesn't work with advanced URLs
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5512
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.0.0, 4.1.0, 4.2.0
>            Reporter: Marcus Sorensen
>             Fix For: 4.4.0
>
>
> Template name checking currently just looks at the very end of the url 
> string. e.g.:
> private void checkFormat(String format, String url) {
>         if((!url.toLowerCase().endsWith("vhd"))
> This breaks functionality such as registering a template via an S3 pre-signed 
> URL, or anything where the file extension is not the last part of the URL. We 
> should at least attempt to parse the URL for filename vs parameters.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to