[ https://issues.apache.org/jira/browse/CLOUDSTACK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094503#comment-14094503 ]
ASF subversion and git services commented on CLOUDSTACK-5512: ------------------------------------------------------------- Commit e3564658befaa72cbe5fd510bea2a25b40f108f5 in cloudstack's branch refs/heads/master from [~minchen07] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e356465 ] CLOUDSTACK-6940, CLOUDSTACK-7312, CLOUDSTACK-5512: Template/ISO/Volume upload rejects some valid URL formats. Also consolidate URL format check into one util routine. > template format name checking is crude and doesn't work with advanced URLs > -------------------------------------------------------------------------- > > Key: CLOUDSTACK-5512 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Affects Versions: 4.0.0, 4.1.0, 4.2.0 > Reporter: Marcus Sorensen > Assignee: Rohit Yadav > Fix For: 4.4.0 > > > Template name checking currently just looks at the very end of the url > string. e.g.: > private void checkFormat(String format, String url) { > if((!url.toLowerCase().endsWith("vhd")) > This breaks functionality such as registering a template via an S3 pre-signed > URL, or anything where the file extension is not the last part of the URL. We > should at least attempt to parse the URL for filename vs parameters. -- This message was sent by Atlassian JIRA (v6.2#6252)