[
https://issues.apache.org/jira/browse/CLOUDSTACK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626176#comment-14626176
]
ASF GitHub Bot commented on CLOUDSTACK-8581:
--------------------------------------------
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34554904
--- Diff:
plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
---
@@ -60,7 +60,9 @@ public DataStoreTO getStoreTO(DataStore store) {
:
Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TIMEOUT)),
details.get(ApiConstants.S3_MAX_ERROR_RETRY) == null ? null
:
Integer.valueOf(details.get(ApiConstants.S3_MAX_ERROR_RETRY)),
details.get(ApiConstants.S3_SOCKET_TIMEOUT) == null ? null
:
Integer.valueOf(details.get(ApiConstants.S3_SOCKET_TIMEOUT)),
imgStore.getCreated(), _configDao.getValue(Config.S3EnableRRS.toString()) ==
null ? false
- :
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())),
getMaxSingleUploadSizeInBytes());
+ :
Boolean.parseBoolean(_configDao.getValue(Config.S3EnableRRS.toString())),
getMaxSingleUploadSizeInBytes(),
+ details.get(ApiConstants.S3_CONNECTION_TTL) == null ? null
: Integer.valueOf(details.get(ApiConstants.S3_CONNECTION_TTL)),
+ details.get(ApiConstants.S3_USE_TCP_KEEPALIVE) == null ?
null : Boolean.parseBoolean(details.get(ApiConstants.S3_USE_TCP_KEEPALIVE)));
--- End diff --
Oh, I agree with you. It's just that I didn't want to touch the formatting
for this patch.
When I looked at the code I had the same idea.
If this PR gets merged I want to send a second commit which fixes this.
> Make S3 TCP KeepAlive and ConnectionTtl configureable
> -----------------------------------------------------
>
> Key: CLOUDSTACK-8581
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8581
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
> Reporter: Wido den Hollander
> Assignee: Wido den Hollander
> Fix For: 4.6.0
>
>
> Currently we can not set the TCP KeepAlive and ConnectionTtl settings for the
> Amazon S3 ClientConfiguration class:
> http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/ClientConfiguration.html
> Our S3Util doesn't set these values so it defaults to what Amazon configures.
> This doesn't work in all situations and we want to make this configurable.
> For example the ConnectionTtl should be lowered in cases where the Object
> Store closes a HTTP connection after a very short period.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
