[ https://issues.apache.org/jira/browse/CLOUDSTACK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628002#comment-14628002 ]
ASF GitHub Bot commented on CLOUDSTACK-8581: -------------------------------------------- Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/582#discussion_r34674108 --- Diff: api/src/com/cloud/agent/api/to/S3TO.java --- @@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) { return false; } + if (connectionTtl != null ? !connectionTtl.equals(thatS3TO.connectionTtl) : thatS3TO.connectionTtl != null) { + return false; --- End diff -- break into readable if-else please > Make S3 TCP KeepAlive and ConnectionTtl configureable > ----------------------------------------------------- > > Key: CLOUDSTACK-8581 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8581 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: SystemVM > Reporter: Wido den Hollander > Assignee: Wido den Hollander > Fix For: 4.6.0 > > > Currently we can not set the TCP KeepAlive and ConnectionTtl settings for the > Amazon S3 ClientConfiguration class: > http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/ClientConfiguration.html > Our S3Util doesn't set these values so it defaults to what Amazon configures. > This doesn't work in all situations and we want to make this configurable. > For example the ConnectionTtl should be lowered in cases where the Object > Store closes a HTTP connection after a very short period. -- This message was sent by Atlassian JIRA (v6.3.4#6332)