[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956567#comment-14956567
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41972355
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
 ---
    @@ -39,4 +39,22 @@ public VspResourceAnswer(VspResourceCommand cmd, 
Exception e) {
         public String getResourceInfo() {
             return this._resourceInfo;
         }
    +
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        VspResourceAnswer that = (VspResourceAnswer) o;
    +
    +        if (_resourceInfo != null ? 
!_resourceInfo.equals(that._resourceInfo) : that._resourceInfo != null)
    +            return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        return _resourceInfo != null ? _resourceInfo.hashCode() : 0;
    +    }
    --- End diff --
    
    We can't, the <code>toString()</code> method is made <code>final</code> in 
the base class <code>Command</code> of which <code>Answer</code> is a subclass


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for 
> this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to