[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956566#comment-14956566
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41972321
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
 ---
    @@ -79,4 +79,41 @@ public String getProxyUserDomainuuid() {
         public boolean executeInSequence() {
             return false;
         }
    +
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        VspResourceCommand that = (VspResourceCommand) o;
    +
    +        if (_childResource != null ? 
!_childResource.equals(that._childResource) : that._childResource != null)
    +            return false;
    +        if (_entityDetails != null ? 
!_entityDetails.equals(that._entityDetails) : that._entityDetails != null)
    +            return false;
    +        if (_method != null ? !_method.equals(that._method) : that._method 
!= null) return false;
    +        if (_proxyUserDomainuuid != null ? 
!_proxyUserDomainuuid.equals(that._proxyUserDomainuuid) : 
that._proxyUserDomainuuid != null)
    +            return false;
    +        if (_proxyUserUuid != null ? 
!_proxyUserUuid.equals(that._proxyUserUuid) : that._proxyUserUuid != null)
    +            return false;
    +        if (_resource != null ? !_resource.equals(that._resource) : 
that._resource != null) return false;
    +        if (_resourceFilter != null ? 
!_resourceFilter.equals(that._resourceFilter) : that._resourceFilter != null)
    +            return false;
    +        if (_resourceId != null ? !_resourceId.equals(that._resourceId) : 
that._resourceId != null) return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        int result = _method != null ? _method.hashCode() : 0;
    +        result = 31 * result + (_resource != null ? _resource.hashCode() : 
0);
    +        result = 31 * result + (_resourceId != null ? 
_resourceId.hashCode() : 0);
    +        result = 31 * result + (_childResource != null ? 
_childResource.hashCode() : 0);
    +        result = 31 * result + (_entityDetails != null ? 
_entityDetails.hashCode() : 0);
    +        result = 31 * result + (_resourceFilter != null ? 
_resourceFilter.hashCode() : 0);
    +        result = 31 * result + (_proxyUserUuid != null ? 
_proxyUserUuid.hashCode() : 0);
    +        result = 31 * result + (_proxyUserDomainuuid != null ? 
_proxyUserDomainuuid.hashCode() : 0);
    +        return result;
    +    }
    --- End diff --
    
    We can't, the <code>toString()</code> method is made <code>final</code> in 
the base class <code>Command</code>


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for 
> this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to