[ https://issues.apache.org/jira/browse/CLOUDSTACK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983619#comment-14983619 ]
ASF GitHub Bot commented on CLOUDSTACK-9004: -------------------------------------------- Github user jharshman commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-152675128 My apologies Daan, I am happy to clarify. The PR for this Jira ticket (9004), was created as a subtask of CLOUDSTACK-8978. It's intent is to add the ability to set certain hv parameters with an end goal in 8978 of implementing hyper-V enlightenment features for Windows Server 2008 guests. The current code for HyperVEnlightenmentFeatureDef only allowed the setting of the hv_relaxed bit. This bit disables a windows sanity check that commonly results in a BSOD when the VM is running on a host under heavy load. The change here adds the ability to set the hv_vapic and hv_spinlocks bits as well as retry time. The hv_vapic bit tries to reduce interrupt overhead in guests. The hv_spinlock bit is used by the guest to notify the hypervisor that the calling virtual processor is attempting to access a resource that may be held by another virtual processor. For the host, the retry value for hv_spinlock indicates the number of times the virtual processor should attempt to access before the spinlock is considered excessive. Basically these changes are setting the stage for changes I am going to submit in CLOUDSTACK-8974. > Add functionality to LibvirtVMDef.HyperVEnlightenmentFeatureDef > --------------------------------------------------------------- > > Key: CLOUDSTACK-9004 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9004 > Project: CloudStack > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM > Affects Versions: 4.5.2 > Reporter: Josh Harshman > Priority: Minor > Labels: easyfix, patch, perfomance, windows > > LibvirtVMDef.HyperVEnlightenmentFeatureDef only supports the setting of the > relaxed mode feature. This change will expand the subclass to be able to set > vapic and spinlock boolean values, as well as spinlock retry value. > These values will then be written out to the XML appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)