[
https://issues.apache.org/jira/browse/CLOUDSTACK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983950#comment-14983950
]
ASF GitHub Bot commented on CLOUDSTACK-9004:
--------------------------------------------
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1013#issuecomment-152724047
@jharshman Very clear Josh. This would be for 4.7 then. based on review you
have my LGTM. We will need to run a test suite before merging but let's wait as
it seems 4.6 can be out next week. I've seen a convention coming up where
people prefix their PRs with [4.7] in the title. it makes sense for you to do
the same
Can you assign both (and any other related) tickets to yourself? Don't
hesitate to call in help if you need to.
Do you have a good integration test environment yourself? It will also help
accepting if you can show how you tested your changes in unit-, system-,
integration tests, though I'm sure we'll manage to get this going.
> Add functionality to LibvirtVMDef.HyperVEnlightenmentFeatureDef
> ---------------------------------------------------------------
>
> Key: CLOUDSTACK-9004
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9004
> Project: CloudStack
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM
> Affects Versions: 4.5.2
> Reporter: Josh Harshman
> Priority: Minor
> Labels: easyfix, patch, perfomance, windows
>
> LibvirtVMDef.HyperVEnlightenmentFeatureDef only supports the setting of the
> relaxed mode feature. This change will expand the subclass to be able to set
> vapic and spinlock boolean values, as well as spinlock retry value.
> These values will then be written out to the XML appropriately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
