[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050424#comment-15050424 ]
ASF GitHub Bot commented on CLOUDSTACK-9114: -------------------------------------------- Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163541774 Hi @ustcweizhou, The content is a bit misleading because you used the ```VpcVirtualNetworkApplianceService``` instead of ```VirtualNetworkApplianceService```. Concerning the tests, I know you did that. But if tomorrow (or within a week) we have to improve it, we will have to do the tests, manually, again. So improving the existing integration test will help everybody. Could you also apply the changes I mentioned against the code, please? Cheers, Wilder > restartnetwork with cleanup should not update/restart both routers at once > -------------------------------------------------------------------------- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Wei Zhou > Assignee: Wei Zhou > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)