[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052367#comment-15052367
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
--------------------------------------------
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163867468
@remibergsma @DaanHoogland
This PR Looks Okay To Me, no good, but okay. Please merge it and I will
improve the code and add Marvin tests to cover it because @ustcweizhou said he
is too busy to do that.
I'm also busy, we are all busy. It should not be used as excuse to avoid
writing tests. Even our managers know that.
I went into berserker mode and told him that next PR without tests will get
a -1 from me, and I will hold to that promise.
Cheers,
Wilder
> restartnetwork with cleanup should not update/restart both routers at once
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wei Zhou
> Assignee: Wei Zhou
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
