[ https://issues.apache.org/jira/browse/CLOUDSTACK-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072621#comment-15072621 ]
ASF GitHub Bot commented on CLOUDSTACK-9132: -------------------------------------------- Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-167540899 @nitin-maharana I did not notice that the other PR was to 4.6, I thought it was to master. I would just ask you to use a Javadoc block over “getVolumeNameFromCommand” instead of a commenting block. At line 487, it is good your code, but we can improve it. The code you wrote is the same as using “org.apache.commons.lang.StringUtils.isBlank(str)”; therefore, I believe you should use the method from “StringUtils” from Apache commons lang. I also recommend you to remove the comments of lines: 362, 369, 376 and 383, those tests names are intuitive, so there is no need to add comment there. > API createVolume takes empty string for name parameter > ------------------------------------------------------ > > Key: CLOUDSTACK-9132 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9132 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API > Reporter: Nitin Kumar Maharana > > Steps to Reproduce: > ================ > Create a volume using createVolume API where parameter name is empty. > It creates a volume with empty name. > But the name parameter is mandatory.(Issue) > Expected Behaviour: > ================ > It shouldn't create a volume with an empty name. Error should be returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)